breadcrumbs and next/prev links is now fixed as navbar #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the bar appears twice when at the top of the page:
Also, it takes up a bit too much of real estate on mobile devices in portrait mode. Example on an iPhoneX:
|
|
🚀 Commit 4cf1d83 Deployed on https://web-php-pr-328.preview.thephp.foundation |
|
I agree with Anna, the bar appears twice |
|
Here's an alternative implementation that moves the breadcrumbs within |
|
No feedback was provided. The issue is being suspended because we assume that you are no longer experiencing the problem. If this is not the case and you are able to provide the information that was requested earlier, please do so. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi !
breadcrumbs and next/prev links is now fixed as navbar
this is necessary in order to make it easier to switch to the next page, since now, after reading the page, you don’t have to scroll to the very beginning of the page